When: 2017-01-17; 12pm ET
Where: Google Hangouts: https://hangouts.google.com/hangouts/_/event/cd3blc5al8lb5v97fc9a3847id0?hl=en&authuser=1
Moderator: Andrew Myers (WGBH)
Review action items†
- Done - Create a PR for issue #19 and get it merged (Drew)
- Done, feel free to suggest changes to wording to make more clear.
- Will discuss more when reporting back on Drew/Elliot dev pair-up.
- Done - Ask for community feedback about #23.
- No feedback forthcoming. Merge it or kill it.
- May be out-of-scope enough to let it go.
- Specifically applies if the plugin is an engine.
- Reinforce this as a best practice when the plugin is an engine. (Drew)
- Done - Solicit feedback on the next hydra-tech call. (Drew)
- More feedback is needed. Any thoughts on ways to improve getting feedback right now?
- Just keep plugging alone for now. Solicit deeper feedback later, when we have more significant changes to suggest/submit as PRs.
- Done - Solicit second round of feedback on the hydra-tech list. (Jenn)
- Dev commitments
- Eliot (4 hours)
- Drew (4 hours)
- Looked at GeoConcerns specifically for sticking points, identifying places where it might be difficult to conform to the guidelines without significant changes to GeoConcerns or CurationConcerns.
- Specifically derivative generation, handling files in a fileset. A lot of file characterization is currently baked into CC, which has forced GC to adopt some practices that do not conform to the guidelines, specifically overwriting CC classes. Formulating guidelines around how to handle inheritance, not overwriting the module upon which the plugin depends.
- Changes around this in GC to conform to guidelines might make implementation significantly easier later.
- Modifying GeoConcerns in Hyrax based on this might be a good place for this group to contribute work.
- Also looked at namespacing concerns in GeoConcerns, tabling for now.
- Recommendation will be to namespace plugin code, not under another namespace, following guidelines for namespacing Rails engines.
- Google Analytics
- Chris (4 hours)
- Greg (4 hours)
- Have not met yet, asynchronously doing code review, will meet soon.
- Not enough traction to yet start opening issues on it. Shooting to do so within these next two weeks.
- Schedule time for pairing (Eliot, Drew, Chris, Greg)
- Not done. Make ticket(s) to write justifications or add existing justifications to guidelines doc.
- Drew opened #27 addressing this.
Not done. Make an issue to choose a namespace scheme and solicit feedback.
Done, see Action Items below.
New/Carryover Action Items†
- Actions Items
- Reinforce #23 as a best practice when the plugin is an engine. (Drew)
- Close namespacing recommendation. (Drew, done)
- Being mindful of our deadline and not allowing this work to drag out, focus on coming up with what we can deliver by the end date. (all)
- Drew (4 hours), Eliot (4 hours), Matthew (4 hours), Carolyn (4 hours) on GeoConcerns, diving into Actors stack.
- Pair-ups to be scheduled on Slack after the meeting.
- Tickets and possible backlog stuff in Hyrax & downward as applicable.
- Google Analytics
- Chris, Greg, Kate have 2 - 4 hours over the next 2 weeks.
- Will pair up over the next 2 weeks.
- User stories, tickets, and 2 - 4 hours of dev.
- Next Meeting†
- When: 2017-01-31; 12pm ET
† - Standing agenda item