Samvera Tech Call 2019-05-01
How to connect: https://psu.zoom.us/j/613720745 (link will launch Zoom client – if you do not have Zoom, expand the instructions below)
Time: 9:00am PDT / Noon EDT
Moderator: Chris Colvard (Deactivated)
Notetaker: James Griffin
Attendees:
- Collin Brittle (Emory)
- tamsin woo (UC Santa Barbara)
- LaRita Robinson (Notre Dame)
- Julie Allinson (CoSector at the U. London)
- jamie (Data Curation Experts)
- Lynette Rayle (Cornell University)
- Gordon Leacock (U. Michigan)
- Randall Floyd (Indiana University)
- Trey Pendragon (Princeton University)
Agenda
Roll call by timezone per following order - ensure notetaker is present (moderator)
folks outside North and South America
Eastern timezone
Central timezone
Mountain timezone
Pacific timezone
folks who were missed or who dialed in during roll call
- Remind everyone to sign in on agenda.
- Welcome all newcomers!
- Agenda (moderator)
- Call for new agenda items (moderator)
- browse-everything maintenance and Interest Group proposal (James Griffin)
- browse-everything Licensing Question (https://github.com/samvera/browse-everything/issues/227)
- Request to review https://github.com/samvera/active_fedora/pull/1385 (James Griffin)
- Request for QA reviewers (Lynette Rayle )
- Slack: How to request to that a channel be closed? (James Griffin)
- Add agenda items here
- Moderator & notetaker for next time
- Moderator:
- Notetaker:
- After call, this week's notetaker should create the agenda for the next call:
Open template agenda titled "Samvera Tech Call 2019-xx-xx"
- Click on ... in the top right corner, and select copy.
- Popup will open for location. It should contain:
- Space: Samvera
- Parent page: 2019
- Select copy. New page should be created.
- Modify the title to remove "copy of", update it with the next date, add moderator, notetaker, and any carry-over agenda info. Click Publish.
- PR Review
- Review issues:
- PR review coordinator for next time:
Notes
BrowseEverything Interest Group CfP
- James has issued a call for participation for a browse-everything IG
- An IG is justified by the need to maintain the browse-everything Gem as a dependency of Hyrax
- Additionally, it must be noted that there is an ongoing discussion relating to the proper licensing of the Gem (https://github.com/samvera/browse-everything/issues/227)
active-fedora
- James issued a Pull Request which introduced support for the indexing of float values into Solr (https://github.com/samvera/active_fedora/pull/1383/files)
- This did not change the underlying Solr configuration, and hence should be backward compatible
- As this is a new feature and not a bug being fixed, James needs change to a minor rather than patch release, but it is otherwise acceptable
Questioning Authority (QA) Reviewers (Lynette)
- Call for participation for reviewers with the QA Gem
- Trey: If there is a shortage of labor, the Component Maintenance Group would be happy to look at this
- This can be placed on the GitHub Project board... https://github.com/orgs/samvera/projects/3
- Randall is currently addressing reviews throughout this week
- GitHub Projects also provides some features for assigning reviewers which might be useful for supporting reviews for pull requests
Slack Channel Closures
- James needs to close #geomodeling (it was started in order to assist with communications for the concluded GIS Data Modeling Working Group)
- What is involved in closing and archiving this?
- No one was certain, but Chris offered to assist James with this
Next Scheduled Samvera Tech. Call
Moderator: LaRita Robinson
Notetaker: James Griffin
Meeting adjourned at 09:22PDT/12:22 EDT
Pull Request Reviews for Hyrax
Question regarding CircleCI (Lynette)
- Changing the cache key for individual files functions, but for directories presents obstacles
- Chris: Avalon developers just used a long cache key in order to respond to directory contents being updated
- In this case, the directory being cached contains fixtures
- Perhaps a step following the engine_cart generation which fetches any new fixtures could be explored?
CircleCI Performance Question (Lynette)
- Tests did not seem to be running reliably for builds of QA
- CircleCI Containers: If two concurrent builds of Hyrax are running, all of the builds within the Samvera GitHub Organization are queued
Pull Requests
There are QA-related PRs (https://github.com/samvera/questioning_authority), and they may block further work being addressed by Lynette
Request for reviewers
Wings PRs
- Chris has been tagging PRs with "wings" for any PRs which emerged from the sprint
- These should be left for review by those on the Hyrax WG or involved in Hyrax on Wings sprints
3479
- Lynette volunteered to review this
3560
- Adds a Rake task for cleaning resources out of Fedora and tables out of databases
- Question about whether it was necessary was raised
- It will require a rebase
3528
- Some additional tests were requested
3652
- James is working on this for this afternoon
3716
- GeoNames improvements for Hyrax
- Backward compatibility, should handle a default parameter for the method #solrize
Also, there is a URL for the GeoNames API hard-coded into the PR - This does not integrate well with QA
- An alternative might use the linked data features in QA
- Lynette would be willing to assist with QA support
3543
- This is ready for another review
- This was scoped for the Hyrax WG sprint
- One week from Monday, someone will be assigned for review
3692
- Adjusting the CircleCI concurrency configuration settings, but it can be left to be closed as a stale
3760
- Requires a new release of riiif, this is not ready for release
3763
- Missing translations, request for reviewers
3764
- There are failing tests for this, the WG can review this
3762
- This will also involve reviewers from the WG
3765
- Copies files into place and installs the UniversalViewer using Yarn
- Separation into a separate Rake task which is invoked by an install generator
3769
- i18n support which needs to have commits squashed (and which has failing tests)
- One should be able to review it
Pull Request review ended at 09:55PDT/12:55 EDT