Samvera Tech Call 2019-07-10 - CANCELLED (Hyrax Pull Request Review Only)

How to connect: https://psu.zoom.us/j/613720745 (link will launch Zoom client – if you do not have Zoom, expand the instructions below)

Time: 9:00am PDT / Noon EDT

Moderator: @tamsin woo

Notetaker: @James Griffin

Attendees:

• @Chris Colvard (Deactivated) (Indiana University)

• @Collin Brittle (Emory University)

• @Julie Allinson (U. London)

• @tamsin woo (UC Santa Barbara)

• @James Griffin (Princeton University)

Agenda

1. Roll call by timezone per following order - ensure notetaker is present (moderator)

   1. folks outside North and South America

   2. Eastern timezone

   3. Central timezone

   4. Mountain timezone

   5. Pacific timezone

   6. folks who were missed or who dialed in during roll call

   7. Remind everyone to sign in on agenda.

   8. Welcome all newcomers!

2. Agenda (moderator)

   1. Call for new agenda items (moderator)

   2. Add agenda items here

3. Moderator & notetaker for next time
   
   

   1. Moderator:

   2. Notetaker:

4. After call, this week's notetaker should create the agenda for the next call:

   1. Open template agenda titled "Samvera Tech Call 2019-xx-xx"

   2. Click on ... in the top right corner, and select copy.

   3. Popup will open for location. It should contain: 

      1. Space: Samvera

      2. Parent page: 2019

   4. Select copy. New page should be created.

   5. Modify the title to remove "copy of", update it with the next date, add moderator, notetaker, and any carry-over agenda info. Click Publish.

5. PR Review
   
   

   1. Review issues:

   2. PR review coordinator for next time: 

Notes

• There will be Hyrax issues which are handled by the Hyrax Working Group

• There are also still outstanding Wings PRs

  • There were some Wings PRs which were stale and closed

  • Should they be reviewed?

  • If somebody is asking for one of them to be reviewed, then we should; otherwise if no one is advocating for a review then perhaps we should not

  • #3479: LaRita authored a sizeable PR

    • It never received a review

    • Chris asked LaRita about this in a GitHub comment

• Julie: Has one waiting for review, but has merge conflicts which shall need to be reviewed (#3760)

  • Wanted a more thorough review before continuing to work to resolve conflicts upstream

  • Rob Kaufman approved of it more than one month ago

  • Did nothing substantive, but did introduce changes which dismissed the approving review

  • Will need to resolve conflicts before approving of the PR?

  • Questions regarding riiif Gem support arose during the review

  • If users haven't installed riiif, there might be an issue; this might need to be tested

  • Inline the ImageMagickInfoExtractor into the Hyrax namespace in order to avoid a hard dependency for Riiif::ImageMagickInfoExtractor

  • Characterization information isn't extracted by the FITS alone; hence the ImageInfoExtractor step is needed in order to resolve this

  • Tom: It's okay to place this in the Hyrax namespace temporarily

  • Then, introduce this into hydra_works and pin to the new release

  • Ultimately, the goal is that hydra_works won't exist after Wings for Hyrax work is completed

  • PR also makes assumptions about the image format (currently only handles JPEG and PNG formats)

  • It does make sense; clients can only request these formats from the Riiif IIIF Image Server

  • Developers might use another IIIF Image Server; they may wish to request a different format from that server

  • IIPImage might return pyramidal TIFFs; should we be concerned about these other cases?

  • A note was made on GitHub; Julie will investigate this further with other possible viewers for a potential unhandled format

  • Might also be able to just comment where there might be concerns; ultimately, those using different IIIF Image Servers are likely to undertake heavy customization regardless

• Most Recent Wings Pull Requests

  • #3877

    • Handling Embargoes using Valkyrie Resources

    • Motivating case for the backend work is to ensure that the VisibilityCopyJob works for Valkyrie::Resources

    • Valkyrie doesn't provide an ID with an API like GlobalID

      • Passing it to an ActiveJob perform method requires a wrapper in order to ensure that Valkyrie::Resources can have IDs passed to ActiveJobs

      • Did not need a NullEmbargo Class; using an empty one was acceptable

    • Uses Embargoes in Valkyrie as nested resources; No longer tracks the ID of the Embargo Valkyrie::Resources

    • Embargo-copying is offered in the EmbargoManager Class

    • Have a work, want the lease to propagate to its FileSets

      • History should not be copied with it, but the visibility should be copied downwards

    • Querying for existing Embargoes becomes specific to Valkyrie, as there are adapter-based methods which need to be invoked in order to find the Embargo by ID