Collection feature specs
Page: Public Collection Show PageĀ
link to code:Ā https://github.com/samvera/hyrax/blob/master/spec/features/collection_spec.rb
Test case code | Comments & questions | Proposed changes to section |
---|---|---|
Basic segments of public collection show page | Looks for basic content | Add expectation for parent collections included |
Behavior variation when using search feature | ||
Basic segments of public collection show page for a non-nestable collection | It appears that this is intended to test that the subcollection list in't included when a collection is not nestable. However, it only tests for basic content, and doesn't test that subcollection content is NOT there, so the test is basically a light version of the first test. | Add expectation that parent collections and subcollections NOT included when collection isn't nestable. |
Pagination of works section of page | Should feature tests really do this sort of test? Would it not be better done as part of a view spec? | Recommend that this be removed. |
Pagination of subcollections section of page | Same comments as re: pagination of works | Recommend that this be removed. |
Page: Dashboard Collection Show PageĀ
link to code:
Test case code | Comments & questions | Proposed changes to section |
---|---|---|