Samvera Tech Call 2017-11-29
!!! Please note that connection info has changed as of October 12th, 2017 !!!
How to connect: https://psu.zoom.us/j/613720745 (link will launch Zoom client – if you do not have Zoom, expand the instructions below)
Time: 9:00am PDT / Noon EDT
Moderator: Jennifer Lindner
Notetaker: James Griffin
Attendees:
- Collin Brittle (Emory)
- Esmé Cowles (Princeton)
- James Griffin (Princeton)
- LaRita Robinson (Notre Dame)
- Jim Coble (Duke)
- Steve Van Tuyl (oregon state university)
- David Tolmie (Univ of Washington)
- Glen Horton (Cincinnati)
- Lynette Rayle (Cornell)
- Adam Wead (Penn State University)
- Anna Headley (Princeton)
- Sean Upton (U. Utah)
- Steven Ng (Temple University)
- Jacob Reed (U. Utah)
- justin (Stanford University)
- Aaron Collier (Stanford University)
- Michael Joseph Giarlo (Stanford University)
Agenda
Roll call by timezone per following order - ensure notetaker is present (moderator)
folks outside North and South America
Eastern timezone
Central timezone
Mountain timezone
Pacific timezone
folks who were missed or who dialed in during roll call
- Welcome all newcomers!
- Agenda (moderator)
- Call for new agenda items (moderator)
- Adding end of life notice to Sufia repository (Jeremy Friesen and justin)
- See PR for reference https://github.com/samvera/sufia/pull/3181
- Proposal to merge collection extensions work into Hyrax master (Michael Joseph Giarlo, Lynette Rayle, Steve Van Tuyl)
- Also, timeline to Hyrax 2.1.0 (incl. CE bugs/features)
- Code review process.
- Testing.
- Migration testing.
- What about these WIP PRs? https://github.com/samvera/hyrax/pulls?q=is%3Aopen+is%3Apr+label%3A%22collections%2Fadmin+sets%22 (Justin)
- How about current master as 2.1.0 & CE as 2.2.0? (Justin)
- Also, timeline to Hyrax 2.1.0 (incl. CE bugs/features)
- https://github.com/samvera/hydra-head/pull/425 (justin)
- Remove seeds.rb?
- Hyrax Analytics Development Effort - https://groups.google.com/d/msg/samvera-tech/LUc1jmm--Yo/cPabaDoFAwAJ (Steve Van Tuyl)
- Notetaker and moderator for next time
- Notes: Jim Coble
- Moderator: Michael Joseph Giarlo
- After call, this week's notetaker should create the agenda for the next call.
Notes
Agenda
End of Life Notice to Sufia
(Jeremy Friesen isn’t on the call)
Should there be another PR for CurationConcerns?
How best to determine an end-of-life time?
Rochkind raised this issue on Slack
Do we, as a community, support this?
Do we steer others elsewhere?
Perhaps ask Friesen to post to the mailing list
Actionable Items:
Post to the mailing list
Sufia will be EOL’d unless someone objects
Friesen will address this
Proposal to Merge Collection Extensions into Hyrax (master)
Van Tuyl:
Collection Extensions work is feeling fully baked and ready to merge into hyrax/master
Normal process of reviewing the code would be a huge burden
Proposal is to merge the extensions work into hyrax/master
Code review has been happening on that branch
QA testing with the collection extensions work has shown it to be in pretty good shape
Rayle:
There are couple of PR’s
Work is not entirely complete (can’t cut release 2.1 immediately after merging the PR)
There are some bugs which have been uncovered while undertaking some additional testing
Level of quality remains consistent
Coyne:
Would anyone like to commit to further testing?
Lindner:
Might it be appropriate to call out to the community?
Rayle:
Full QA process will be applied to it
Currently, there is overhead in keeping hyrax/master and working branches in sync
Merging might raise exposure and render it easier to contribute
Coyne:
It sounds like this is okay
Headley:
Concerned over past merges from branches with non-complete features
Would prefer a greater degree of completion
Ensure that new Classes have a fair amount of documentation (lessening the learning curve)
Rayle:
Inviting persons to inspect documentation with respect to YARD
Coyne:
Should provide a window of time
Lindner:
Perhaps have high-level documentation for remaining features?
Robinson:
Has nesting functional, deleting the relationships isn’t wired to the UI yet
Hopes that by the end of this week this can be finished
Van Tuyl:
Wait to merge to hyrax/master until the nesting work is completed?
Rayle:
About to be out of town, will have limited communication
Ordinarily, 1 week is not a major deal
But, there were 20 commits to hyrax/master recently
Coyne:
No major contributions to hyrax/master this week
Next week is the Valkyrie/Hyrax sprint
Van Tuyl:
Can we move forward to merge with an expectation for polish after Rayle returns?
Coyne:
Make a PR after Johnson has her work in
Headley:
Should we consider halting merges to hyrax/master until this is finished?
Coyne:
Would that be necessary? Only conflicts typically halt progress
Van Tuyl:
(After much discussion in the group), proceed without delaying merging commits to hyrax/master
Rayle:
Should attempt to avoid to introduce any major changes
Current Master as 2.1.0 and Collections Extension 2.2.0
Coyne:
Would like to see a release prior to merging collections extension sprint work
Prefers a 2.1 release
Rayle:
Challenges lie in requesting the same parties for multiple QA sprints
Coyne:
Concerned that this limits the number of releases which can be supported by the community
Slows the release process as a consequence
Van Tuyl:
What is the expected testing regimen for minor releases?
Perhaps focus on the new functionality be introduced (focused regression testing)Communicate with Justin and Aaron about what changes were made
Focus the testing on that work
Giarlo:
Take the idea to Julie Rudder and repository managers and then consult with Coyne and others who would like to see an earlier release
Goal is to balance between more frequent releases as a community and higher quality releases (i. e. more testing)
ActiveFedora 12 into hydra-head
Coyne:
Request to have someone review the outstanding pull request
Lindner volunteers to review and ask questions about the structure
seeds.rb
Coyne:
Relic from CurationConcerns
Doesn’t work because “GenericWork” hard-coded
(Unless the App. features this Work, this isn’t too useful)
Giarlo:
Useful for bootstrapping an App, and should just be moved into a Rake Task
Rayle:
Nested collections testing discovered this
Ideally, use this for adding fixtures for specific cases within QA testing (such as adding users with particular roles)
Coyne:
This is just fixture data for manual testing?
Rayle:
Yes, uncertain about embargo fixtures
Robinson:
In favor of a Rake Task, but should be wary
Coyne:
Will rework this into a solution other than seeds.rb
Hyrax Analytics Development Effort
Out of time
Please visit the linked thread (https://groups.google.com/d/msg/samvera-tech/LUc1jmm--Yo/cPabaDoFAwAJ) and contact Van Tuyl if one is interested in helping