Samvera Tech Call 2021-08-25

Owned by Juliet Hardesty
Last updated: Aug 25, 2021 by James Griffin
2 min read

Meeting Logistics:

Agenda

(meeting notes below)


Moderator: Juliet Hardesty

Notetaker: James Griffin

Attendees:


Meeting Process

 Moderator and Note Taker - click to see meeting process...
  1. Standing pre-agenda items (moderator)

    1. Welcome

      • "Welcome everyone, please add your name to the Attendees list.  If you are unable to do so, please let us know, and someone will add you. To any newcomers, Welcome, and please feel free to ask questions. Likewise for all attendees. We strive for an open and accessible conversation around Samvera technology."

    2. Call for new agenda items
  2. Follow Agenda from above (facilitated by moderator) and record notes in Notes section below (note taker)
  3. Standing post-agenda items (moderator)
    1. call for next moderator and note taker (moderator)
      1. Moderator:
      2. Notetaker:
    2. Samvera help follow-up (moderator)
    3. Pull request review (moderator)
  4. Post-meeting action (note taker)
    1. After call, this week's notetaker should create the agenda for the next call:
      1. Open template agenda titled "Samvera Tech Call 2021-xx-xx"
      2. Click on ... in the top right corner, and select copy.
      3. Popup will open for location. It should contain:
        1. Space: Samvera
        2. Parent page: 2021
      4. Select copy. New page should be created.
      5. Modify the title to remove "copy of", update it with the next date, add moderator, notetaker, and any carry-over agenda info. Click Publish. 


Notes

  • Hyrax Routing (Lynette)
    • Notes: https://confluence.cornell.edu/x/HuQIG 
    • If you have an instance of the `Hyrax::AdministrativeSet`, `to_model_name` uses `singular_route_key`
      • `admin_set_path` is generated from this
      • `polymorphic_path` is called...uses this `singular_route_key` method
      • `ContentEventJob` raises a NoMethodError
      • Hyrax::Monograph does work however
    • ContentEventJob uses the Rails::Routes::Helper
      • ActiveModel#name somehow keeps the proper path from being generated
      • What does `ActiveFedora::AdminSet` normally do?
      • The ActiveModel#name is most likely not being overridden properly
    • include ActionView::Helpers
      • This within ContentEventJob is likely related to problems also
    • Larger problem: `link_to(some_admin_set)` is going to break
    • Hyrax::ResourceName is specific to the Valkyrie::Resource Models
      • This is necessary for generating the `ActiveModel#name` which is valid
      • This might be explored also
  • Exploring the User Interface on the main branch, a bug was discovered for creating Monographs
    • Lynette created issue #5084 in response to this
  • Next Scheduled Tech. Call
    • Moderator: Tamsin
    • Notetaker: James
  • Samvera Help Follow-Up
  • Pull Request Review
    • Hyrax
      • Many are still just drafts
      • 5082 https://github.com/samvera/hyrax/pull/5082 should be merged to assist with reviewing and merging other pull requests
        • This is a parameterization of a previously-coded collaborator
        • The git diff may be difficult to visually parse, but hopefully there won't be much overlap
      • 5077 https://github.com/samvera/hyrax/pull/5077
        • This should be closed, and contributors should plan to use a generic `SystemUser` for this case
        • Both of the EventJobs and notifications require some `User` to be attached
          • Should this be similar to the AuditUser?
          • Yes, this should work
        • This will be closed then


Call concluded at 12:31 EDT/09:31 PDT