Skip to end of metadata
Go to start of metadata

You are viewing an old version of this page. View the current version.

Compare with Current View Page History

Version 1 Next »

Public Collection https://github.com/samvera/hyrax/blob/master/spec/features/collection_spec.rb

Test case codeWhat are we testingComments & questions
https://github.com/samvera/hyrax/blob/master/spec/features/collection_spec.rb#L21-L38Basic page content
https://github.com/samvera/hyrax/blob/master/spec/features/collection_spec.rb#L40-L55Behavior during search
https://github.com/samvera/hyrax/blob/master/spec/features/collection_spec.rb#L57-L66UnclearThe intent of this test case is unclear. It appears that this is intended to test that the subcollection list in't included when a collection is not nestable. However, it only tests for basic content, and doesn't test that subcollection content is NOT there, so the test is basically worthless.
https://github.com/samvera/hyrax/blob/master/spec/features/collection_spec.rb#L71-L91Pagination of works

Should feature tests really do this sort of test? Would it not be better done as part of a view spec?

There is no wrapper of each section, so how can we differentiate works pagination from subcollection or parent collection pagination?

https://github.com/samvera/hyrax/blob/master/spec/features/collection_spec.rb#L93-L113Pagination of subcollectionsSame comments as re: pagination of works

Dashboard Collection

Test case codeWhat are we testingComments & questions



  • No labels