Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

Most relevant candidate jobs for refactoring

...

./content_event_job.rb           https://github.com/samvera/hyrax/issues/4193

./inherit_permissions_job.rb   https://github.com/samvera/hyrax/issues/4200 

./attach_files_to_work_with_ordered_members_job.rb   https://github.com/samvera/hyrax/issues/4201 

./content_restored_version_event_job.rb   https://github.com/samvera/hyrax/issues/4202 

Event jobs

Events may or may not operate on an instance of a repository object; if they do, they should be covered by ContentEventJob:

./content_delete_event_job.rb   Doesn't involve an actual object instance, just an object ID
./content_deposit_event_job.rb  Should be covered by refactor of content_event_job
./content_update_event_job.rb   Should be covered by refactor of content_event_job

Refactor?

Do these files make sense to refactor for AF or Valkyrie?

./create_work_job.rb
./batch_create_job.rb
./ingest_job.rb

The following jobs potentially call perform with an ActiveFedora object and have not yet been refactored to accept a Valkyrie resource:

./file_set_attached_event_job.rb
./fixity_check_job.rb
./inherit_permissions_job.rb
./attach_files_to_work_with_ordered_members_job.rb
./user_edit_profile_event Should be covered by refactor of content_event_job

Refactor?

These jobs involve creating works - do these make sense to refactor?

./create_work_job.rb
./content_restored_version_eventbatch_create_job.rb
./content_new_version_eventingest_job.rb