...
- 17 are open
- Valkyrie Pull Request
- chromedriver
- https://github.com/samvera/hyrax/pull/3335
- CLA was not legal to sign
- https://github.com/samvera/hyrax/pull/3362
- If the last comment was a question, it requires a response
- https://github.com/samvera/hyrax/pull/3370 was approved
- Any progress from Tom Johnson on getting the CircleCI builds to pass?
- Stubbed requests need to be torn down for feature tests, WebMock is disabling the requests between suites, but the tests will pass
- Will require merges over CircleCI failures (these merges should have a comment detailing this)
- https://github.com/samvera/hyrax/issues/3373 was created to address this
- https://github.com/samvera/hyrax/pull/3374
- Whether this goes into 3.0 or not?
- PR is fine
- Plan is to integrate for the 3.0 release
- https://github.com/samvera/hyrax/issues/3364
- In last week's review, attendees skipped all tagged for the 3.0 release
- https://github.com/samvera/hyrax/issues/3368
- Also requires a check for the CLA
- https://github.com/samvera/hyrax/pull/3380
- Was already approved, merged during the call
- https://github.com/samvera/hyrax/pull/3383
- Not sure why I18n.with_local for English is used
- Forces into English
- smithjp of UNC
- Left a comment on the issue (https://github.com/samvera/hyrax/issues/3321)
- Perhaps this was meant to set up code for easier translations beyond English for later pull requests?
- https://github.com/samvera/hyrax/issues/3337
- Discussion still needed
- https://github.com/samvera/hyrax/pull/3375
- Added the backwards-compatible label
- Myers asked of Tom whether or not these labels
...
- should be applied
- https://github.com/samvera/hyrax/pull/3384
- Notes a UI discrepancy between disabled and enabled buttons
- Please add feedback for UI changes address for the 3.0 release
Notes for the Next Session
- Last week, Myers created a search for all of the issues to link to in these notes
...
- One should use a date range for issues
Diaz volunteered to take notes
Earlier, Allinson volunteered to serve as the facilitator
Colvard volunteered to serve as the facilitator/moderator
Myers, Leacock, and Diaz needed to leave the meeting at 12:32 EST
Diaz volunteered to take notes
Colvard volunteered to serve as the facilitator/moderator