How to connect: https://psu.zoom.us/j/613720745 (link will launch Zoom client – if you do not have Zoom, expand the instructions below)

Click to view telephone/H.323/SIP connection instructions

Telephone:

Meeting ID: 613 720 745

+1 646 876 9923 (US Toll)
+1 669 900 6833 (US Toll)
+1 408 638 0968 (US Toll)
International numbers available: https://psu.zoom.us/zoomconference?m=UZ_PRwQ56TNX1pDIsdDInAu8XPVqzlX3

H.323:

Meeting ID: 613 720 745

162.255.37.11 (US West)
162.255.36.11 (US East)
221.122.88.195 (China)
115.114.131.7 (India)
213.19.144.110 (EMEA)
202.177.207.158 (Australia)
209.9.211.110 (Hong Kong)
64.211.144.160 (Brazil)
69.174.57.160 (Canada)

SIP: 613720745@zoomcrc.com

Time: 9:00am PDT / Noon EDT

Moderator: Andrew Myers

Notetaker: James Griffin

Attendees:

Gordon Leacock (University of Michigan)
Frederick Rodriguez (Yale University)
James Griffin (Princeton University Library)
Chris Colvard (Deactivated) (Indiana University)
Chris Diaz
Julie Allinson

Agenda

Roll call by timezone per following order - ensure notetaker is present (moderator)
1. folks outside North and South America
2. Eastern timezone
3. Central timezone
4. Mountain timezone
5. Pacific timezone
6. folks who were missed or who dialed in during roll call
7. Remind everyone to sign in on agenda.
8. Welcome all newcomers!
Agenda (moderator)
1. Call for new agenda items (moderator)
2. add agenda item here
Moderator & notetaker for next time
1. Moderator:
2. Notetaker:
After call, this week's notetaker should create the agenda for the next call:
1. Open template agenda titled "Samvera Tech Call 2018-xx-xx"
2. Click on ... in the top right corner, and select copy.
3. Popup will open for location. It should contain:
  1. Space: Samvera
  2. Parent page: 2018
4. Select copy. New page should be created.
5. Modify the title to remove "copy of", update it with the next date, add moderator, notetaker, and any carry-over agenda info. Click Publish.
PR Review (Chris Colvard (Deactivated))
1. Review PRs deemed priority from any Samvera project.
2. Review Hyrax PRs, sorted by 'Least recently updated' and filter out any that don't need to be considered.
3. Next Facilitator: Julie Allinson

Notes

No Tech. Call was held, instead the Hyrax PR Review was held immediately

Request Review Session

Myers: Call for high priority pull requests requiring review?
Colvard: Notes that there are some updates required in relation to the sass Gem (3.7.0)
bootstrap-sass Gem fails compilation due to this update
Release 3.7.1 for sass is needed in order to address this properly

Hyrax

17 are open
Valkyrie Pull Request
chromedriver
https://github.com/samvera/hyrax/pull/3335
- CLA was not legal to sign
https://github.com/samvera/hyrax/pull/3362
- If the last comment was a question, it requires a response
https://github.com/samvera/hyrax/pull/3370 was approved
- Any progress from Tom Johnson on getting the CircleCI builds to pass?
- Stubbed requests need to be torn down for feature tests, WebMock is disabling the requests between suites, but the tests will pass
- Will require merges over CircleCI failures (these merges should have a comment detailing this)
- https://github.com/samvera/hyrax/issues/3373 was created to address this
https://github.com/samvera/hyrax/pull/3374
- Whether this goes into 3.0 or not?
- PR is fine
- Plan is to integrate for the 3.0 release
https://github.com/samvera/hyrax/issues/3364
- In last week's review, attendees skipped all tagged for the 3.0 release
https://github.com/samvera/hyrax/issues/3368
- Also requires a check for the CLA
https://github.com/samvera/hyrax/pull/3380
- Was already approved, merged during the call
https://github.com/samvera/hyrax/pull/3383
- Not sure why I18n.with_local for English is used
- Forces into English
  - smithjp of UNC
- Left a comment on the issue (https://github.com/samvera/hyrax/issues/3321)
- Perhaps this was meant to set up code for easier translations beyond English for later pull requests?

https://github.com/samvera/hyrax/issues/3337
- Discussion still needed
https://github.com/samvera/hyrax/pull/3375
- Added the backwards-compatible label
- Myers asked of Tom whether or not these labels should be applied
https://github.com/samvera/hyrax/pull/3384
- Notes a UI discrepancy between disabled and enabled buttons
- Please add feedback for UI changes address for the 3.0 release

Notes for the Next Session

Last week, Myers created a search for all of the issues to link to in these notes
One should use a date range for issues
Diaz volunteered to take notes
Earlier, Allinson volunteered to serve as the facilitator
Colvard volunteered to serve as the facilitator/moderator

Myers, Leacock, and Diaz needed to leave the meeting at 12:32 EST

Browser not supported