Page Comparison

...

1. Roll call by timezone per following order - ensure notetaker is present (moderator)

   1. folks outside North and South America

   2. Eastern timezone

   3. Central timezone

   4. Mountain timezone

   5. Pacific timezone

   6. folks who were missed or who dialed in during roll call

   7. Welcome all newcomers!
2. Agenda (moderator)
   1. Call for new agenda items (moderator)
   2. Collection Extensions update (Lynette Rayle)
      
      1. PR: https://github.com/samvera/hyrax/pull/2623
      2. Documentation: Collections and Admin Sets - Overview
      3. Partipation Info:  Collection Extensions Hyrax 2.1.0 - QA and Release
   3. Hyrax PR reviewing (Chris Colvard (Deactivated))
      1. @samvera/hyrax-code-reviewers
      2. PR backlog
   4. (After Call) Valkyrie Sprint Planning - Scheduling & Tickets
   5. add agenda item here
3. Notetaker and moderator for next time
   
   1. Notes:
   2. Moderate:
4. After call, this week's notetaker should create the agenda for the next call.

...

• PR created to merge collection extensions work into master – https://github.com/samvera/hyrax/pull/2623 .
• Documentation for collection extensions functionality – Collections and Admin Sets - Overview– in addition to overview, see also documentation on collection types – http://samvera.github.io/collection-types.html .
• Wiki page to sign up for QA testing and bug fixing – Collection Extensions Hyrax 2.1.0 - QA and Release .
• Props from the community to Lynette Rayle for her work on the documentation and to jrudder for her work on the release process.

...

• There are some Hyrax PR's that have been languishing for a while.
• Developers are encouraged to review the Github Hyrax Code Reviewers list – https://github.com/orgs/samvera/teams/hyrax-code-reviewers/members– and update it as appropriate.  Chris Colvard (Deactivated) will email the samvera-tech list about this as well.
• Discussion about increasing throughput on Hyrax PR reviews
  • Perhaps post outstanding PR's as an agenda item on the tech call as a place to talk about them during the call?
  • Would it be worthwhile to spend some time in a call looking at a PR together as an exemplar of how to do code review?  Or perhaps this should be separated out into its own call for a time or two?
  • Would be good to have at least a basic checklist for code reviewing.  Does anything exist that could be a starting point?  Some suggestions ...
    • Code Contribution Guidelines
    • https://github.com/samvera/hyrax/blob/master/.github/CONTRIBUTING.md#reviewing-and-merging-changes
    • https://samvera.github.io/best-practices-coding-styles.html
    • https://samvera.github.io/how-to-pr.html
  • Trey Pendragon created an issue for samvera.github.io about documentation for how to review a PR – https://github.com/samvera/samvera.github.io/issues/193 .  Will tag common code reviewers to comment on the issue to offer suggestions about what should be in the documentation.
  • Good article on code reviewing: https://medium.com/@sandya.sankarram/unlearning-toxic-behaviors-in-a-code-review-culture-b7c295452a3c .
  • Discussed idea of matching reviewers with code areas they feel comfortable reviewing so that PR submitters could potentially tag appropriate people as reviewers.  Might be a good idea but is likely to be difficult to maintain.  Alternatively, PR submitters could use 'git blame' to get a sense of who has done work on the code in question and might be a good reviewer.
  • What is our goal in reducing the PR backlog?  If outstanding for over a week, it really should be reviewed (unless it's clearly a work-in-progress PR).
  • Jim Coble will add an agenda item to next week's call to check in on how some of these plans are progressing.

...