...
Page: Public Collection Show Page
link to code: https://github.com/samvera/hyrax/blob/master/spec/features/collection_spec.rb
What are we testinghttps://github.com/samvera/hyrax/blob/master/spec/features/collection_spec.rb#L57-L66 | Unclear | The intent of this test case is unclear. https://github.com/samvera/hyrax/blob/master/spec/features/collection_spec.rb#L21-L38 | Basic page content | https://github.com/samvera/hyrax/blob/master/spec/features/collection_spec.rb#L40-L55 | Behavior during search | worthless.https://github.com/samvera/hyrax/blob/master/spec/features/collection_spec.rb#L71-L91a light version of the first test. | Add expectation that parent collections and subcollections NOT included when collection isn't nestable. |
Pagination of works section of page | Should feature tests really do this sort of test? Would it not be better done as part of a view spec?
There is no wrapper of each section, so how can we differentiate works pagination from subcollection or parent collection pagination? |
https://github.com/samvera/hyrax/blob/master/spec/features/collection_spec.rb#L93-L113 Page: Dashboard Collection Show Page
link to code:
What are we testing | Comments & questions | Proposed changes to section |
---|
|
|
|