Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Page: Public Collection Show Page 

link to code: https://github.com/samvera/hyrax/blob/master/spec/features/collection_spec.rb

Test case code
What are we testinghttps://github.com/samvera/hyrax/blob/master/spec/features/collection_spec.rb#L57-L66UnclearThe intent of this test case is unclear.
Comments & questions
https://github.com/samvera/hyrax/blob/master/spec/features/collection_spec.rb#L21-L38Basic page contenthttps://github.com/samvera/hyrax/blob/master/spec/features/collection_spec.rb#L40-L55Behavior during search
Proposed changes to section
Basic segments of public collection show pageLooks for basic contentAdd expectation for parent collections included
Behavior variation when using search feature

Basic segments of public collection show page for a non-nestable collectionIt appears that this is intended to test that the subcollection list in't included when a collection is not nestable. However, it only tests for basic content, and doesn't test that subcollection content is NOT there, so the test is basically
worthless.https://github.com/samvera/hyrax/blob/master/spec/features/collection_spec.rb#L71-L91
a light version of the first test.Add expectation that parent collections and subcollections NOT included when collection isn't nestable.
Pagination of works section of page

Should feature tests really do this sort of test? Would it not be better done as part of a view spec?

There is no wrapper of each section, so how can we differentiate works pagination from subcollection or parent collection pagination?

https://github.com/samvera/hyrax/blob/master/spec/features/collection_spec.rb#L93-L113
Recommend that this be removed.
Pagination of subcollections section of pageSame comments as re: pagination of worksRecommend that this be removed.

Page: Dashboard Collection Show Page 

link to code:

Test case code
What are we testing
Comments & questionsProposed changes to section