Page Comparison

...

• Jim Coble (Duke University)
• Trey Pendragon (Princeton University)
• Andrew Myers (WGBH)
• Anna Headley (Princeton University)
• Andrew Myers (WGBH)
• Collin Brittle (Emory)
• LaRita Robinson (Notre Dame)
• Thomas Scherz (U. Cincinnati)
• Chris Colvard (Deactivated) (Indiana University)
• tamsin woo (UC Santa Barbara)
• Gordon Leacock (University of Michigan)
• To be added

Agenda

1. Roll call by timezone per following order - ensure notetaker is present (moderator)

   1. folks outside North and South America

   2. Eastern timezone

   3. Central timezone

   4. Mountain timezone

   5. Pacific timezone

   6. folks who were missed or who dialed in during roll call

   7. Remind everyone to sign in on agenda.
   8. Welcome all newcomers!
2. Agenda (moderator)
   
   1. hydra-pcdm Ancestor Validation for Collection/Sub-Collection Nesting (James Griffin)
      1. https://github.com/samvera/hydra-pcdm/issues/245
      2. Note: I've spoken to Lynette earlier today, and given that she is unavailable for the call this week, this issue will be added to the agenda for next week
   2. Developer's congress communication: making an announcement (Anna Headley)
      1. Developer Congress - Monday 21st October 2019
   3. Samvera Docs WG rejuvenation (Andrew Myers)
   4. Add agenda items here
3. Moderator & notetaker for next time
   
   1. Moderator:
   2. Notetaker:
4. After call, this week's notetaker should create the agenda for the next call:

   1. Open template agenda titled "Samvera Tech Call 2019-xx-xx"

   2. Click on ... in the top right corner, and select copy.
   3. Popup will open for location. It should contain: 
      1. Space: Samvera
      2. Parent page: 2019
   4. Select copy. New page should be created.
   5. Modify the title to remove "copy of", update it with the next date, add moderator, notetaker, and any carry-over agenda info. Click Publish.
5. PR Review
   
   1. Review issues:
   2. PR review coordinator for next time: 

...

Component Maintenance WG will be contacted in preparation for the migration to the new theme

Next Scheduled Samvera Tech. Call

Moderator: LaRita

Notetaker: James

Call concluded at 09:24 PDT/12:24 EDT

Hyrax Pull Request Review Session

Attendees

• Chris Colvard
• Gordon Leacock
• James Griffin

3760

Still waiting on Julie Allinson

3839

Sprinters still working on Wings

3881

Covered by the Hyrax WG

It has been reviewed

Tom asked for changes

3764

Chris will be undertaking a review

3479

Needs another review

3899

Anyone can review this now, not just Tom

Bring Hyrax up to Rails 5.2

CircleCI build restructured into two different workflows

In the Gemfile.lock, Rails, when generating internal test app., hard-coded a Rails version into the test app.

This really couldn't be addressed without using workspaces between jobs (otherwise the invalid Gemfile.lock would be persisted)

Trying to make the tests pass with a new release of hydra-editor with simple_form updates with Rails 5.2 has been the challenge

simple_form was using #to_model which

Also before_destroy: remove! was creating problems

ActiveRecord in earlier Rails was throwing StatementInvalid where it should have been throwing more specific errors

3907

This should be closed in favor of https://github.com/samvera/maintenance/issues/27

3908

This might be a Hyrax WG issue

Inclined to leave them for the WG

Test failure may have been a flapping test, Chris is rerunning the build

It was indeed a flapping test

This still needs a review

Different solution might be to permit users create a TransferRequest when FlipFlop has transfer works is enabled

Defer to someone in the WG

3909

3762 became stale

user_id and grantee_id HTTP request parameter parsing raised some questions

Also questions regarding `head :ok` statements

Is a modal preferable to a flash message?

Non-Hyrax Pull Requests

(Nothing was proposed)

Session concluded at 09:49 PDT/12:49 EDT