How to connect: https://psu.zoom.us/j/613720745 (link will launch Zoom client – if you do not have Zoom, expand the instructions below)
Time: 9:00am PDT / Noon EDT
Moderator: cam156
Notetaker: James Griffin
Attendees:
- Collin Brittle(Emory)
- Jim Coble (Duke)
- cam156 (PSU)
- Gordon Leacock (Umich)
- valerie
- LaRita Robinson (Notre Dame)
- Trey Pendragon (Princeton)
- Andrew Myers (WGBH)
- Thomas Scherz (Cincinnati)
- Daniel Pierce (Indiana University)
- Chris Colvard (Deactivated) (Indiana University)
- Lynette Rayle (Cornell)
Agenda
Roll call by timezone per following order - ensure notetaker is present (moderator)
folks outside North and South America
Eastern timezone
Central timezone
Mountain timezone
Pacific timezone
folks who were missed or who dialed in during roll call
- Remind everyone to sign in on agenda.
- Welcome all newcomers!
- Agenda (moderator)
- Call for new agenda items (moderator)
- Promoting Valkyrie from Samvera-Labs (https://docs.google.com/document/d/1zZzelSFFCZpE4_wji4eOAk1P0QOPhAa5JPUudLCxtas/edit?usp=sharing)
- Documentation Working Group (Andrew Myers or LaRita Robinson)
- add agenda item here
- Moderator & notetaker for next time
- Moderator:
- Notetaker:
- After call, this week's notetaker should create the agenda for the next call:
Open template agenda titled "Samvera Tech Call 2019-xx-xx"
- Click on ... in the top right corner, and select copy.
- Popup will open for location. It should contain:
- Space: Samvera
- Parent page: 2019
- Select copy. New page should be created.
- Modify the title to remove "copy of", update it with the next date, add moderator, notetaker, and any carry-over agenda info. Click Publish.
- PR Review
- Review issues:
- PR review coordinator for next time:
Notes
Promoting Valkyrie from samvera-labs (Carolyn Cole)
- Document provided by Carolyn Cole
- Additional comments on the document are welcome
- No further comments on the document on the call
Documentation WG (LaRita Robinson)
- Andrew Myers and LaRita met yesterday
- Looking for more members
- Restructuring the site...content is not growing due to a lack of membership, but additional content is still needed
- Agreed yesterday to push 1-2 issues each week
- Created a project board for priority issues
- Try to capture from members who might be knowledgeable, who might be able to fill holes in documentation
- This week, focusing on workflows and mediated deposits
- It was started but left incomplete, looking for volunteers who have experience working with this in Hyrax or Samvera apps
- Go to issue, add comments, offer oneself as a person of contact
- WG will create the actual content for the site
- This will hopefully make it easier to create documentation for the site
- Suggestions for the topics are welcome, create a GitHub issue or contact LaRita or Drew
- Call for volunteers
- Specific focus upon creating custom workflows
- Document how this was successfully undertaken
- Jim Coble
- At Duke University, custom workflows were created
- It was a minor change to a default workflow
Moderator:
Chris Colvard
Notetaker:
Thomas Scherz
Meeting was adjourned at 09:11EST/12:11 EST
Hyrax Pull Request Reviews
Attendees
Pull Request 3548
- Chromedriver was failing, this PR installs Google Chrome on CircleCI build containers in order to ensure that Chrome is always stable
- It does ensure that we remain dependent upon Debian package releases for Chrome stable
- It was merged
Pull Request 3541
- Draft PR (new feature introduced by GitHub)
- Merge icon is grey, otherwise not easily distinguishable from normal PRs
- Could apply "in progress" label, but this would be unnecessary
- Should we review them? Or wait for them to become full PRs?
- This already had a review
- "in progress" labels would only be useful if Waffle is used for tracking issues
- Chris commented requesting a rebase
Backport PRs for CircleCI
Pull Request 3546
- Transaction becomes a no-op actor
- Already merged into master, deals with the issue where if you hit an exception in the actor stack, it renders the system unusable
- IDs would be rolled back (NOIDs), but Fedora wouldn't roll back its own resource
- NOID would be minted using a Fedora ID for a Fedora resource which already existed
- This would result in a LDP Conflict
- This PR ensures that the conflicts are handled and resolved
- Tom Johnson will handle the CI build issues
Pull Request 3543
- Alerts users of data loss when moving between tabs while editing Collection metadata
- No tests are present in the PR
- This behavior may already be there for certain cases, but not for all cases
- Tom Johnson commented only 15 hours before this call
Pull Request 3545
- This is another backport
- This should require a rebase
Pull Request 3544
- (This is the same case as 3545)
Pull Request 3468
- This has not had any activity since last week
- It was marked as stale, Chris and Tom discussed this last week
- Tom just needs to come back and introduce additional commits
Pull Request 3489
- This has had no activity since last week
- Invite someone from the analytics sprint to perform a review
Pull Request 3472
- This is going to be abandoned in favor of a PR being introduced by Tom Johnson
Pull Request 3431
- Chris and Tom discussed this last week
- Backports support for dealing with transactional request in Noid/Fedora conflict resolution (addressing the same problem as 3546)
- Lynette Rayle provided a different solution, which set up validation for identifiers
- Having Noid::Rails check to see if the ID is already in use, and then know to generate a new one
- It does work and solves a larger problem
- However, there are concerns about it introducing performance issues
- Noid ID minting calls out to Fedora, potentially twice (to determine if it exists, two HEAD requests are issued)
- Unnecessary overhead...and it is dealt with in backports
- Tom suggested that this just be closed
- Perhaps place this in the management guide rather than just the README
- "If you're running into problems, and you need strict validation, you can follow this pattern"
- Chris commented on the PR
3504
- Holdover from last Hyrax/Valkyrie sprint, still WIP
Review concluded at 09:36PST/12:36EST