...
- PR #5157 - Collection basic metadata should be opt-in by the application
- PR #5511 - make change set forms allow multiple values for title
- PR #5518 - adds deprecation notices for transactions/steps that are no longer supported
- Trying to get back to collection nesting
...
- Offers to pair.
- Idea:
rspec --only-failures
: can we put the result in the artifacts of circleCI? And then recombine the 10 files to let us download it and use it locally.- https://relishapp.com/rspec/rspec-core/docs/command-line/only-failures
- Check whether the file exists on CI
- This could really help in a scenario where there are 200 failures
- Make a discussion or design ticket?
- Output of valkyrie index: sometimes the key is a string and sometimes a symbol. Can / should we use one or the other?
- In the solr document they're all strings.
- It would be easier to test if it were consistent. The base indexer uses strings.
- Make a refactor ticket. We'll need to update a bunch of tests to do this.
- In blacklight
id
is a symbol and everything else is a string. - Can/should we use
with_indifferent_access
?
- Listeners
- I don't think the listeners are used in active fedora. They often have code that kicks out of the method if there's an AF resource.
- (In this case it doesn't)
- Post in slack if you have a PR that needs to be review or re-reviewed!
Week 2
...
Updates Mar 14
Chris
- I'm here this week part-time
- Looking for a new ticket
Eliot
- Continuing work from last week on parent editing issue
- bug appears to be in PcdmMemberPresenterFactory - it's not fully tested and there's a subtlety with solr
- Have a fix, refactoring it
Shaun
- PR #5527 about date column consistency ready for review
- The date modified column will be blank until the resource is updated
- There's a draft PR to fall back on date uploaded (#5526)
- One proposal is to create a solr field for the latest date
- Another option is to back the logic up into the presenter
- Lynette will look and recommend.
- Planning to pick up one of the issues to add valkyrie feature tests
- Offer to pair
Anna
- Working on 5457 still.
- Noticing that we pass resources directly rather than IDs. It would be good to inventory and move to passing IDs and loading objects, especially in listeners and jobs.
Lynette
- Shepherding PRs
- About to look at issues again to see what our biggest blockers are
- We're doing good work!
- Need review of #5472 (seeds)
- Will go back to nested collections
Updates Mar 15
Updates Mar 16
...