PR #5157 - Collection basic metadata should be opt-in by the application
PR #5511 - make change set forms allow multiple values for title
PR #5518 - adds deprecation notices for transactions/steps that are no longer supported
Trying to get back to collection nesting

Updates Mar 11

Chris

Anna

Working on when you try to make a work as a proxy depositor you can't set it to public visibility.
- It also doesn't go through as a proxy depositor.
- Figured out where it's going wrong - working on a fix.
- Problem was a race condition on the listener

Trey

Eliot

continuing work on parent editing issue
Blocked on a test that fails in CI (which uses engine cart)
May be helpful to reference the PR from earlier this week that added a feature test for searching.
Lynette can pair.

Lynette

Trying to separate out some work that allows for empty values and doesn't actually save them in the data.
Working on test failures
Then plan to go back to the nesting

Daniel

Thumbnail work - put up a branch and working on some failing tests
nurax-pg - PR with docker compose fixes ready for review
- Uses hyrax main branch (doesn't try to mount a local development hyrax)

Tao

Used a new admin user to do testing on collection type
- Still get an error when editing a collection type

Shaun

Working on PR#5508 - seems ready to go at this point, pending CI
Had to guard against nil date updated values. Use date uploaded as a backup value. May want to refactor at some point.
Maybe add a solr document method like document.latest_date?

Agenda:

Offers to pair.
Idea: rspec --only-failures: can we put the result in the artifacts of circleCI? And then recombine the 10 files to let us download it and use it locally.
- https://relishapp.com/rspec/rspec-core/docs/command-line/only-failures
- Check whether the file exists on CI
- This could really help in a scenario where there are 200 failures
- Make a discussion or design ticket?
Output of valkyrie index: sometimes the key is a string and sometimes a symbol. Can / should we use one or the other?
- In the solr document they're all strings.
- It would be easier to test if it were consistent. The base indexer uses strings.
- Make a refactor ticket. We'll need to update a bunch of tests to do this.
- In blacklight id is a symbol and everything else is a string.
- Can/should we use with_indifferent_access?
Listeners
- I don't think the listeners are used in active fedora. They often have code that kicks out of the method if there's an AF resource.
- (In this case it doesn't)
Post in slack if you have a PR that needs to be review or re-reviewed!

Versions Compared