...
- PR #5157 - Collection basic metadata should be opt-in by the application
- PR #5511 - make change set forms allow multiple values for title
- PR #5518 - adds deprecation notices for transactions/steps that are no longer supported
- Trying to get back to collection nesting
...
- Checking in to see if there are things for her to look at from this morning.
- Will try a few things that aren't part of main yet, but could be merged in.
- (Lynette) One for sure is Geonames where it gets whole state/country - make sure Julie's okay with that.
- Changes to UI stuff, but that's all merged.
- (Anna) Maybe we should release this rollback of the somethingsomethingActor.
- Think it's the cause of a problem with Duke.
- Julie's out Thursday/Friday this week. Is a release something we can manage by end of tomorrow, or maybe release 3.3.1 next week?
- Lynette will look at that PR and see if it can just get in and get a release out tomorrow.
- Does Julie have to be around for the release?
- What about ActiveFedora reversion?
- Happened
- 3.3.1 release should happen after these 3 PRs are merged/done. If we want to do it tomorrow, Julie is around except for an hour in the afternoon.
- Emory may join for maintenance next week. Any valkyrie issues expected to remain?
- Yeah probably.
- Lynette will be minimalist for the next couple of weeks.
Updates Mar 16
Updates Mar 17
Updates Mar 18
See Retros Dev Congress March 7-18PRs merged: 28
Eliot
- Valkyrie Parent Resources to add/remove children. Adding a new transaction to make that happen. Just about done.
Shaun
- Working on issue Valkyrie Collection Creation Testing #4590. Collection feature test is having some problems. Not sure where UI is. 3 failing tests. Can't find title and description field for one scenario.
- Pulled out repeated test login into separate tests.
Anna
- About to look at the status of my open PR #5537. Concerns about backwards compatibility. We are changing it from invoking a background job that calls a service, to directly calling the service first and then invokes a background job. Lynnette has no problem with the transaction actor. Changing the way the job works is maybe a little harder. Lynette suggests perhaps deprecating the listener, but needs to think about it. Anna says that we will need to continue to support that listener which could be a nightmare. It's possible that there hasn't been a release since that listener, but Anna contends that it was introduced at least a year ago. If the listener is a concern we may have to revert that PR. If the Job is a concern, we could deprecate the Job and the Service and we can introduce new ones. Lynette wants to look at it again.
- Question about use of FindBy vs FindByAlternateId...
- Issue #4085
- Lynnette says the way Wings is written, it uses FindByAlternateId when FindBy is called.
- Lynnette wonders if there will be a problem when data gets migrated as the NOID used may not be its actual id.
Thanya (not present)
- Looked at the Default Search ticket. Will write up some notes on what she learned and will un-assign herself from the ticket.
Lynette
- Wrapping up issue #5449
- Prioritize PR reviews and will take a look at the Default Search ticket.
Chris
- Working on issue that if a collection has works within it, they are not showing up on the count on the dashboard, and not showing up on the collection show.
- Working on a feature test for it.
Updates Mar 17
Eliot
- Couple PRs in review column. Lynette reviewed PR about adding stuff to a PR, made a comment. Split off into separate ticket? Open to whatever.
- Fine to do a separate ticket for that. We can merge what's in there now.
- Another PR for review which enables search for child functionality in a Valkyrie edit page.
- Pushing up a PR to fix 5452 to fix citation button.
Anna
- Chat about deprecation concerns for work doing for 5457. Spent time working on deprecation stuff. Really close on all of the deprecations - for this PR just created need to fix a couple of tests. Want to address comments from previous PR.
- Will make a couple tickets.
- Started looking at the seed PR and then looked at deprecation stuff instead. Will try and get back to it.
Shaun
- No updates, doing local work.
Lynette
- Put in tests for nested collection. Just tested with main and something's not quite right. Getting an error again. Will take another look at it again.
Trey
- Can try and pick up one of the tickets that got created.
- Look at if manifest generation is broken for regular hyrax resources.
- Message from Julie 3/16 at 14:27 eastern on #hyrax-valkyrie indicates that image display in viewers are broken
Updates Mar 18
See Retros Dev Congress March 7-18
33 PRs!
Chris
- Working on feature tests for valkyrie
- If you enable an adapter other than Wings, hide the Wings constant altogether
- "tests with the most LDP requests" now has zero tests listed
- Working through load and authorize before action – collection class is only provided at load time so this makes it hard in the test.
- Maybe specify a method instead, which can then check the config.
- At the end of this we should be able to do work by cloning and updating a feature test, then making it pass
Eliot
- Shepherding some PRs. One outstanding is one that updates hyrax on nurax-pg. How does this get deployed?
- Lynette manually deploys this
- Hopefully this will allow us to close more tickets that have been fixed by other work
Shaun
- Have been working on 4590
- failures encountered:
- There's no description in the form for valkyrie collections
- there's an undefined method banner_info
- These are both known issues and both are under current development.
- failures encountered:
Tao
- Back today
Anna
- working on proxy deposit. First PR is green and ready to merge. Second PR is still in progress.
- Working on adding another PR that would break out the processing of files into a background job.
Lynette
- Lots of code review
- worked on debugging universal viewer on nurax-dev
- fits wasn't being called correctly > characterization not happening > images don't display in viewer
- wasn't a code issue
Julie
- 3.3.1 bugfix release? Do we want to do this on Monday?
- Let's answer this after Anna's PRs go in
- UV not an issue
- still holding off on GeoNames – we can talk to Daniel on Monday
- this will require 3.4
- We need a 3.4 anyway because of deprecation with proxy depositor code – needs a release note.
- Lynette and Julie will talk more
- If we want both releases we need to do it via backporting
Trey
- Hi friends!