How to connect: https://notredame.zoom.us/j/94030214208 (link will launch Zoom client – if you do not have Zoom, expand the instructions below)
Expand | ||
---|---|---|
| ||
Meeting ID: 940 3021 4208 One tap mobile
Dial by your location
Meeting ID: 940 3021 4208 Find your local number: https://notredame.zoom.us/u/aPls29JbL Join by SIP 94030214208@zoomcrc.com Join by H.323
Meeting ID: 940 3021 4208 |
Time: 9:00am PDT / Noon EDT
...
Roll call by timezone per following order - ensure notetaker is present (moderator)
folks outside North and South America
Eastern timezone
Central timezone
Mountain timezone
Pacific timezone
folks who were missed or who dialed in during roll call
- Remind everyone to sign in on agenda.
- Welcome all newcomers!
- Agenda (moderator)
- Call for new agenda items (moderator)
- Hyrax Telemetry? (tamsin woo )
- Hyrax 3.0.0.rc2 release notes (Jeremy Friesen)
- I have a pass for adding all of the PRs and fixed issues since https://github.com/samvera/hyrax/releases/tag/v3.0.0-rc1
- I need guidance on what the tag should be (so I can upload the release notes, which have some todo items for review)
- <add open agenda items here>
- Samvera help follow-up
- Pull request review
- PR/4463 - allow for extensions of valkyrie indexer's to_solr that depends on resource custom metadata (Lynette)
- Moderator & notetaker for next time
- Moderator:
- Notetaker:
- After call, this week's notetaker should create the agenda for the next call:
Open template agenda titled "Samvera Tech Call 2020-xx-xx"
- Click on ... in the top right corner, and select copy.
- Popup will open for location. It should contain:
- Space: Samvera
- Parent page: 2020
- Select copy. New page should be created.
- Modify the title to remove "copy of", update it with the next date, add moderator, notetaker, and any carry-over agenda info. Click Publish.
- PR Review
- Review issues:
- PR review coordinator for next time:
...
- https://github.com/samvera/hyrax/pull/4463 by Lynette
- Introduces improvements to the shared specs for Valkyrie
- If you add anything to `to_solr`, then the shared specs will fail
- The way that the shared specs are processed, `let` calls can be overridden outside of the scope of the shared specs
- Custom metadata is introduced into the test suite for modeling cases where Hyrax adopters who index custom metadata fields using the Solr indexer
- One can pass in a custom indexer without a problem, and then the metadata is pulled from a fixed Resource, rather than one set by the user
- Should introduce the `thumbnail_id` handling for `nil` values in a different pull request
- This blocks the tests from passing
- Lynette could not find why `thumbnail_id` was created with a blank string for the test
- One should also be able to simply invoke `thumbnail_id.present?`
- If not, that is a Valkyrie bug
- `let(:resource)` needed to be added in order to ensure that these shared specs are not breaking for Hyrax adopters with customized applications
- For anybody using this test suite as written, it is currently broken
- Prefer not to parameterize the test suites
- Want to avoid replication with `let` calls
- If I pass in a `Resource` to the shared spec, the shared spec shouldn't know the permissions on the `Resource`
- Hence, the permissions are set within the scope of the shared spec
- `VisibilityWriter` needs to be removed, this was just copied from a factory
- Each Indexer is tied to a specific type of Resource
- Perhaps they shouldn't be
- If something more generic without requiring Indexer customization were introduced, then `to_solr` would include many `#try` calls
- Introduces improvements to the shared specs for Valkyrie