Page Comparison

How to connect: https://notredame.zoom.us/j/94030214208 (link will launch Zoom client – if you do not have Zoom, expand the instructions below)

Time: 9:00am PDT / Noon EDT

...

1. Roll call by timezone per following order - ensure notetaker is present (moderator)

   1. folks outside North and South America

   2. Eastern timezone

   3. Central timezone

   4. Mountain timezone

   5. Pacific timezone

   6. folks who were missed or who dialed in during roll call

   7. Remind everyone to sign in on agenda.
   8. Welcome all newcomers!
2. Agenda (moderator)
   1. Call for new agenda items (moderator)
   2. Hyrax Telemetry? (tamsin woo )
   3. Hyrax 3.0.0.rc2 release notes (Jeremy Friesen)
      1. I have a pass for adding all of the PRs and fixed issues since https://github.com/samvera/hyrax/releases/tag/v3.0.0-rc1
      2. I need guidance on what the tag should be (so I can upload the release notes, which have some todo items for review)
   4. <add open agenda items here>
   5. Samvera help follow-up
   6. Pull request review
      1. PR/4463 - allow for extensions of valkyrie indexer's to_solr that depends on resource custom metadata (Lynette)
3. Moderator & notetaker for next time
   
   1. Moderator:
   2. Notetaker:
4. After call, this week's notetaker should create the agenda for the next call:

   1. Open template agenda titled "Samvera Tech Call 2020-xx-xx"

   2. Click on ... in the top right corner, and select copy.
   3. Popup will open for location. It should contain: 
      1. Space: Samvera
      2. Parent page: 2020
   4. Select copy. New page should be created.
   5. Modify the title to remove "copy of", update it with the next date, add moderator, notetaker, and any carry-over agenda info. Click Publish.
5. PR Review
   
   1. Review issues:
   2. PR review coordinator for next time: 

...

• https://github.com/samvera/hyrax/pull/4463 by Lynette
  • Introduces improvements to the shared specs for Valkyrie
    • If you add anything to `to_solr`, then the shared specs will fail
    • The way that the shared specs are processed, `let` calls can be overridden outside of the scope of the shared specs
  • Custom metadata is introduced into the test suite for modeling cases where Hyrax adopters who index custom metadata fields using the Solr indexer
  • One can pass in a custom indexer without a problem, and then the metadata is pulled from a fixed Resource, rather than one set by the user
  • Should introduce the `thumbnail_id` handling for `nil` values in a different pull request
    • This blocks the tests from passing
    • Lynette could not find why `thumbnail_id` was created with a blank string for the test
    • One should also be able to simply invoke `thumbnail_id.present?`
      • If not, that is a Valkyrie bug
  • `let(:resource)` needed to be added in order to ensure that these shared specs are not breaking for Hyrax adopters with customized applications
  • For anybody using this test suite as written, it is currently broken
  • Prefer not to parameterize the test suites
    • Want to avoid replication with `let` calls
  • If I pass in a `Resource` to the shared spec, the shared spec shouldn't know the permissions on the `Resource`
    • Hence, the permissions are set within the scope of the shared spec
  • `VisibilityWriter` needs to be removed, this was just copied from a factory