...
Tech Call concluded at 09:10PDT/12:10 EDT
Hyrax PR Pull Request Review Session
Attendees:
- Chris Colvard
- Tom Johnson
- Gordon Leacock
Pull Request 3996
- README improvements
- Chris approved of those changes
Rails 6 pull request is just a placeholder
Wings pull requests are ready for review, but other PRs are not ready
3969
- Requires some additional attention
- Build cache in CircleCI does not have 2.x/3.x separated by the cache key
- This might be a good change to introduce in the CircleCI Orb
- Wants to load sass-rails 5, but sass-rails is locked at 6
- It is possible that backporting a CircleCI config. is needed
3945
- Requires a bit more work or a test restart
- Intermittent failure is what was blocking the tests from passing
- Tom had some comments, requested to approve it as a result
- It may still need to be rebased
- Also request that the commit message be improved
4012
- Pretty significant step on the migration of models away from ActiveFedora
- Might be worth offering this for review by those uninvolved in the Wings work
- hyrax-valkyrie Channel:
- Names for classes `QueryServiceBook` and `QueryServiceImage`
- Should namespace `Book` vs. `BookResource`
- There were also errors in code documentation for the examples
There are ActiveFedora pull requests which also require review
ActiveFedora 13.1.0 release would be ideal
Pull Request review session concluded at 09:29 PDT/12:29 EDT