Page Comparison

...

PR #5157 - Collection basic metadata should be opt-in by the application
PR #5511 - make change set forms allow multiple values for title
PR #5518 - adds deprecation notices for transactions/steps that are no longer supported
Trying to get back to collection nesting

...

Updates Mar 16

...

Eliot

Valkyrie Parent Resources to add/remove children. Adding a new transaction to make that happen. Just about done.

Shaun

Working on issue Valkyrie Collection Creation Testing #4590. Collection feature test is having some problems. Not sure where UI is. 3 failing tests. Can't find title and description field for one scenario.
Pulled out repeated test login into separate tests.

Anna

About to look at the status of my open PR #5537. Concerns about backwards compatibility. We are changing it from invoking a background job that calls a service, to directly calling the service first and then invokes a background job. Lynnette has no problem with the transaction actor. Changing the way the job works is maybe a little harder. Lynette suggests perhaps deprecating the listener, but needs to think about it. Anna says that we will need to continue to support that listener which could be a nightmare. It's possible that there hasn't been a release since that listener, but Anna contends that it was introduced at least a year ago. If the listener is a concern we may have to revert that PR. If the Job is a concern, we could deprecate the Job and the Service and we can introduce new ones. Lynette wants to look at it again.
Question about use of FindBy vs FindByAlternateId...
- Issue #4085
- Lynnette says the way Wings is written, it uses FindByAlternateId when FindBy is called.
- Lynnette wonders if there will be a problem when data gets migrated as the NOID used may not be its actual id.

Thanya (not present)

Looked at the Default Search ticket. Will write up some notes on what she learned and will un-assign herself from the ticket.

Lynette

Chris

Working on issue that if a collection has works within it, they are not showing up on the count on the dashboard, and not showing up on the collection show.
Working on a feature test for it.

Eliot

Couple PRs in review column. Lynette reviewed PR about adding stuff to a PR, made a comment. Split off into separate ticket? Open to whatever.
- Fine to do a separate ticket for that. We can merge what's in there now.
Another PR for review which enables search for child functionality in a Valkyrie edit page.
Pushing up a PR to fix 5452 to fix citation button.

Anna

Chat about deprecation concerns for work doing for 5457. Spent time working on deprecation stuff. Really close on all of the deprecations - for this PR just created need to fix a couple of tests. Want to address comments from previous PR.
Will make a couple tickets.
Started looking at the seed PR and then looked at deprecation stuff instead. Will try and get back to it.

Shaun

Lynette

Put in tests for nested collection. Just tested with main and something's not quite right. Getting an error again. Will take another look at it again.

Trey

Can try and pick up one of the tickets that got created.
Look at if manifest generation is broken for regular hyrax resources.
Message from Julie 3/16 at 14:27 eastern on #hyrax-valkyrie indicates that image display in viewers are broken

...